Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Codecov v4 #6271

Merged
merged 2 commits into from
Apr 11, 2024
Merged

Codecov v4 #6271

merged 2 commits into from
Apr 11, 2024

Conversation

danmar
Copy link
Owner

@danmar danmar commented Apr 11, 2024

v3 has problems with uploading results. That should be fixed in v4.

@firewave
Copy link
Collaborator

The issue is that v3 uses the v4 API which requires a token. So updating it to v4 should do not anything.

Installing the codecov app for the repo might fix this this. See https://trac.cppcheck.net/ticket/12112.

@danmar
Copy link
Owner Author

danmar commented Apr 11, 2024

The issue is that v3 uses the v4 API which requires a token

codecov v3 uses codecov v4 API?

didn't you mean it uses github v4 API?

@danmar
Copy link
Owner Author

danmar commented Apr 11, 2024

I was inspired by this:
kubeedge/kubeedge#5530

and hoped the same would work for us.

@firewave
Copy link
Collaborator

See codecov/codecov-action#1359 for the upstream issue. And https://github.com/codecov/codecov-action?tab=readme-ov-file#v4-release for the release notes.

@danmar
Copy link
Owner Author

danmar commented Apr 11, 2024 •
edited
Loading

See codecov/codecov-action#1359 for the upstream issue. And https://github.com/codecov/codecov-action?tab=readme-ov-file#v4-release for the release notes.

Well the upload worked.
https://github.com/danmar/cppcheck/actions/runs/8644847325/job/23700822390?pr=6271

at least as far as I can tell.

@firewave
Copy link
Collaborator

That is really strange. It should permanently fail with v4 because we have no token. Something is very wrong there. And still not having a single reply is also not comforting (there are very few replies to issues with that action in general).

So go ahead with the update to v4.

@danmar danmar merged commit d43a1b3 into danmar:main Apr 11, 2024
64 checks passed
@firewave
Copy link
Collaborator

Still fails but in a different way:

==> Running command '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov create-commit'
/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov create-commit --git-service github -Z
gpg: directory '/home/runner/.gnupg' created
gpg: keybox '/home/runner/.gnupg/pubring.kbx' created
gpg: /home/runner/.gnupg/trustdb.gpg: trustdb created
gpg: key 806BB28AED779869: public key "Codecov Uploader (Codecov Uploader Verification Key) <[email protected]>" imported
gpg: Total number processed: 1
gpg:               imported: 1

gpg: Signature made Wed Apr 10 17:26:31 2024 UTC
gpg:                using RSA key 27034E7FDB850E0BBC2C62FF806BB28AED779869
gpg: Good signature from "Codecov Uploader (Codecov Uploader Verification Key) <[email protected]>" [unknown]
gpg: WARNING: This key is not certified with a trusted signature!
gpg:          There is no indication that the signature belongs to the owner.
Primary key fingerprint: 2703 4E7F DB85 0E0B BC2C  62FF 806B B28A ED77 9869

==> Uploader SHASUM verified (2c9804ba263ba6880d67a671c35388a72fbfe014bd814acd212d8ff38644bf91  codecov)
info - 2024-04-11 14:14:42,614 -- ci service found: github-actions
Error: Codecov token not found. Please provide Codecov token with -t flag.
Error: Codecov: Failed to properly create commit: The process '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov' failed with exit code 1

That's obviously the error you get when there is no token - as pointed out by the v4 release notes. So the issue with v3 is something different.

firewave added a commit to firewave/cppcheck that referenced this pull request Apr 11, 2024
@firewave
Revert "Codecov v4 (danmar#6271)"
241ac6c 
This reverts commit d43a1b3.
@firewave firewave mentioned this pull request Apr 11, 2024
Merged
@danmar
Copy link
Owner Author

danmar commented Apr 11, 2024

I'm sad that it didn't work after all :-(

Thanks for your fix.

firewave added a commit that referenced this pull request Apr 11, 2024
@firewave
Revert "Codecov v4 (#6271)" (#6273)
25768b4 
This reverts commit d43a1b3.
@danmar danmar deleted the codecov-v4 branch April 12, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@firewave firewave firewave left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danmar @firewave